[PATCH] D26830: [libcxx] Add string_view literals

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 12 23:12:46 PDT 2017


EricWF added inline comments.


================
Comment at: test/std/strings/string.view/string.view.literals/literal2.pass.cpp:16
+
+int main()
+{
----------------
EricWF wrote:
> What's the point of this test that `literal.pass.cpp` doesn't cover?
Ping on this comment.


================
Comment at: test/std/strings/string.view/string.view.literals/literal3.pass.cpp:16
+
+int main()
+{
----------------
EricWF wrote:
> You can move this test into `literal.pass.cpp` but putting it at another function scope.
Ping on this comment.


https://reviews.llvm.org/D26830





More information about the cfe-commits mailing list