r300151 - Fix broken test. We can't assume that 2MB of args is enough to require a response file.

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 12 17:46:50 PDT 2017


Author: rsmith
Date: Wed Apr 12 19:46:50 2017
New Revision: 300151

URL: http://llvm.org/viewvc/llvm-project?rev=300151&view=rev
Log:
Fix broken test. We can't assume that 2MB of args is enough to require a response file.

This test has apparently been broken for years, but we never noticed before
because it's a long test and long tests approximately never get run.

Modified:
    cfe/trunk/test/Driver/response-file.c

Modified: cfe/trunk/test/Driver/response-file.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/response-file.c?rev=300151&r1=300150&r2=300151&view=diff
==============================================================================
--- cfe/trunk/test/Driver/response-file.c (original)
+++ cfe/trunk/test/Driver/response-file.c Wed Apr 12 19:46:50 2017
@@ -9,11 +9,12 @@
 
 // Check that clang is able to process long response files, routing a long
 // sequence of arguments to other tools by using response files as well.
-// We generate a 2MB response file to be big enough to surpass any system
-// limit.
+// We generate a 2MB response file to attempt to surpass any system limit.
+// But there's no guarantee that we actually will (the system limit could be
+// *huge*), so just check that invoking cc1 succeeds under these conditions.
+//
 // RUN: %clang -E %S/Inputs/gen-response.c | grep DTEST > %t.1.txt
 // RUN: %clang -E @%t.1.txt %s -v 2>&1 | FileCheck %s -check-prefix=LONG
-// LONG: Arguments passed via response file
 // LONG: extern int it_works;
 
 #ifdef TEST




More information about the cfe-commits mailing list