[PATCH] D31996: Make Gentoo GNU GCC Config override whitespace tolerant
Craig Topper via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 12 16:24:39 PDT 2017
craig.topper added inline comments.
================
Comment at: lib/Driver/ToolChains/Gnu.cpp:2176
for (StringRef Line : Lines) {
+ StringRef TrimLine = Line.trim();
// CURRENT=triple-version
----------------
Can we just do
Line = Line.trim()
so we won't have an extra StringRef and no one can misuse the untrimmed on in the future.
https://reviews.llvm.org/D31996
More information about the cfe-commits
mailing list