[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 11 08:32:42 PDT 2017


ABataev added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:499
+        options::OPT_fopenmp_ptx_EQ);
+    CC1Args.back() = (!PtxVersion.empty()) ? PtxVersion.data() : "+ptx42";
+  } else
----------------
No, use `CC1Args.push_back()` here, or `CC1Args.emplace_back()`, which is even better.
Why you don't want to use the code I proposed in my previous comment?


Repository:
  rL LLVM

https://reviews.llvm.org/D29660





More information about the cfe-commits mailing list