[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

Mads Ravn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 10 11:07:49 PDT 2017


madsravn added a comment.

In https://reviews.llvm.org/D30158#702778, @jroelofs wrote:

> In https://reviews.llvm.org/D30158#702760, @madsravn wrote:
>
> > In https://reviews.llvm.org/D30158#699342, @jroelofs wrote:
> >
> > > In https://reviews.llvm.org/D30158#699132, @madsravn wrote:
> > >
> > > > In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote:
> > > >
> > > > > In https://reviews.llvm.org/D30158#696534, @madsravn wrote:
> > > > >
> > > > > > Any updates on this?
> > > > >
> > > > >
> > > > > Have you run it over the test suite on the revision before random_shuffle was removed from libc++?
> > > >
> > > >
> > > > I can't find any more tests for random_shuffle. I have looked in the SVN log for from december 2014 until now. It works on the three tests currently in trunk.
> > >
> > >
> > > Try just before r294328.
> >
> >
> > I can't see any random_shuffle tests in the libc++ repo before r294328 either. I don't know if they aren't there or if I just can't find them. Would you be able to point them out for me with revision and path?
>
>
> Did you look at the diff from the commit I mentioned? That's the one that removed them.


I found them and I have tested them all. This check works fine on them.


https://reviews.llvm.org/D30158





More information about the cfe-commits mailing list