[PATCH] D31765: Skip Unicode character expansion in assembly files

[Oliver Stannard via Phabricator via cfe-commits]

olista01 added a comment.

The change itself looks fine, but I have a few comments on the test.

Tests of clang shouldn't actually run the assembler, as I think this one will fail if clang is built without the ARM backend. A better way to write the test would be to just run the preprocessor, and check that the occurrences of \u make it through unmodified.

You should also be able to use clang's -verify option to check the diagnostics, so that you don't need a dummy warning to avoid empty FileCheck input. Grep for expected-no-diagnostics in the existing tests for examples of this.


https://reviews.llvm.org/D31765