[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

[Akira Hatanaka via Phabricator via cfe-commits]

ahatanak added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:8024
+  bool RHSNatVec = RHS.get()->IgnoreImpCasts()->getType()->isVectorType();
+
+  if (LHSNatVec ^ RHSNatVec) {
----------------
I think "!=" is easier to understand than "^" here.


================
Comment at: lib/Sema/SemaExpr.cpp:8305
 
-  // If there's an ext-vector type and a scalar, try to convert the scalar to
+  // If there's an vector type and a scalar, try to convert the scalar to
   // the vector element type and splat.
----------------
"a vector"


https://reviews.llvm.org/D25866