[PATCH] D30009: Add support for '#pragma clang attribute'

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: docs/LanguageExtensions.rst:2380
+
+The ``__declspec`` style syntax is also supported. A single push directive
+accepts only one attribute regardless of the syntax used.
----------------
Might as well add an example for __declspec (since the other two have it), and move the restriction about the number of attributes supplied to its own paragraph for greater clarity.


================
Comment at: include/clang/Basic/DiagnosticGroups.td:462
 def IgnoredPragmas : DiagGroup<"ignored-pragmas", [IgnoredPragmaIntrinsic]>;
 def Pragmas : DiagGroup<"pragmas", [UnknownPragmas, IgnoredPragmas]>;
+def PragmaClangAttribute : DiagGroup<"pragma-clang-attribute">;
----------------
Should `PragmaClangAttribute` be added here as well?


Repository:
  rL LLVM

https://reviews.llvm.org/D30009