[PATCH] D30087: [Driver] Unify linking of OpenMP runtime
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 5 12:44:04 PDT 2017
ABataev added inline comments.
================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:430
+bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC,
+ const ArgList &Args, const JobAction &JA,
+ bool GompNeedsRT) {
----------------
Do you really need to pass a reference to `JobAction` here or it is enough to pass a bool value for `JA.isHostOffloading()`?
================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:443-445
+ if (GompNeedsRT) {
+ CmdArgs.push_back("-lrt");
+ }
----------------
Remove braces here
https://reviews.llvm.org/D30087
More information about the cfe-commits
mailing list