[PATCH] D30009: Add support for '#pragma clang attribute'

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 5 04:49:41 PDT 2017


arphaman added inline comments.


================
Comment at: lib/Sema/SemaAttr.cpp:578
+    return;
+  Diag(PragmaAttributeStack.back().Loc, diag::warn_pragm_attribute_no_pop_eof);
+}
----------------
aaron.ballman wrote:
> Perhaps adding a FixIt here would be a kindness?
Where would the fix-it point to? I think only the user will know the location at which they meant to insert `#pragma clang attribute pop`.


Repository:
  rL LLVM

https://reviews.llvm.org/D30009





More information about the cfe-commits mailing list