[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

[Yaron Keren via Phabricator via cfe-commits]

yaron.keren added inline comments.


================
Comment at: cmake/modules/HandleLLVMOptions.cmake:562
   add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG)
+else()
+  append("-w" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
----------------
note this is an else to 
if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))
so for non-gcc non-clang_cl compilers you'd also end up here.

shouldn't the condition be
if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT LLVM_ENABLE_WARNINGS)



Repository:
  rL LLVM

https://reviews.llvm.org/D31702