[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

Renato Golin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 3 04:53:09 PDT 2017


rengolin added a comment.

Hi Graham,

It looks much simpler now, thanks!

I'm ok with the change, but I'd like @ABataev to confirm that the semantics is the expected one for all cases and approve.

cheers,
--renato



================
Comment at: lib/Parse/ParseOpenMP.cpp:174
+      case OMPD_target_teams_distribute_simd:
+        DKind = OMPD_simd;
+        break;
----------------
I'd like @ABataev to confirm this is the right semantics.


================
Comment at: lib/Parse/ParseOpenMP.cpp:1047
+    // as the filter function will have switched the kind.
+    if (!getLangOpts().OpenMPSimd)
+      Diag(Tok, diag::err_omp_unknown_directive);
----------------
What if it's really unknown, even to `-fopenmp-simd`?


https://reviews.llvm.org/D31417





More information about the cfe-commits mailing list