[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

Oliver Stannard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 31 08:27:07 PDT 2017


olista01 added a comment.

What advantages does this have over the current way of printing diagnostics? If this is just to get -w and -Werror working, would it not be easier to pass those through to the assembler, than to send all diagnostics back through clang? We already have some flags in MCTargetOptions that should be able to to the same things -w and -Werror do.

On the other hand, if this would enable other features, like -W options to promote/suppress categories of assembler warnings, than this might allow us to avoid duplicating a lot of clang's diagnostic system in the LLVM SourceMgr. Do you have any ideas for how this could be done?


https://reviews.llvm.org/D31501





More information about the cfe-commits mailing list