[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 31 00:07:41 PDT 2017


Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.

Out of interest: This is a limition of the implementation, right? Because the standard only says: `A throw executed inside a target region must cause execution to resume within the same target region, and the same thread that threw the exception must catch it.`



================
Comment at: test/OpenMP/target_parallel_no_exceptions.cpp:14
+    {
+      a = inc(a);
+    }
----------------
Please make the test be valid OpenMP: `inc` is not in `declare target` and it's also a data race.

I think it's enough to only have a `target` construct in the test.


Repository:
  rL LLVM

https://reviews.llvm.org/D29904





More information about the cfe-commits mailing list