rogfer01 added inline comments. ================ Comment at: lib/Driver/ToolChains/Clang.cpp:1882 + TakeNextArg = true; } } else { ---------------- I wonder if you should `break;` here if validation fails like the original code did? https://reviews.llvm.org/D31496