[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

[Martin Böhme via Phabricator via cfe-commits]

mboehme added inline comments.


================
Comment at: docs/clang-tidy/checks/modernize-noexcept-correctness.rst:7
+This check will mark functions as noexcept if that is possible.
+`noexcept` is a new keyword in C++ 11 to signal, that no exception will escape from 
+the function annotated with it. Some examples to show how this new feature is used are below.
----------------
Eugene.Zelenko wrote:
> Please highlight language constructs with ``.
Omit comma before "that".


================
Comment at: docs/clang-tidy/checks/modernize-noexcept-correctness.rst:27
+
+    // Definitly throw an exception on one path. The check will not analyze if this
+    // path is actually executed (in this function it wouldn't!).
----------------
Typo: "Definitely"


================
Comment at: test/clang-tidy/modernize-noexcept-correctness.cpp:61
+// This one is hard, since one must figure out if all possible exceptions are handled.
+// I think that is to complex (for now) and should be let alone. So the programmer
+// must ensure its correctly either marked noexcept or not.
----------------
 Typos: "too complex", "left alone"


Repository:
  rL LLVM

https://reviews.llvm.org/D31370