[PATCH] D31272: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added inline comments.


================
Comment at: lib/CMakeLists.txt:155
+        # We can't use the "-reexported_symbols_list" when we build the
+        # new/delete operators as part of the dylib: the linker would fail.
+        set(OSX_RE_EXPORT_LINE "-Wl,-reexport_library,${CMAKE_OSX_SYSROOT}/usr/lib/libc++abi.dylib")
----------------
EricWF wrote:
> Please explain that the linker will fail because `libc++abi` also provides those definitions.
Mmmm, actually no, the linker fails because libc++ provide those definition.
The linker complains because we can't ask to export the definitions from libc++abi while we already have some definitions!


https://reviews.llvm.org/D31272