[PATCH] D29599: Clang Changes for alloc_align

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 29 13:27:57 PDT 2017


erichkeane marked 2 inline comments as done.
erichkeane added inline comments.


================
Comment at: include/clang/Basic/AttrDocs.td:252
+declaration to specify that the return value of the function (which must be a
+pointer type) has an alignment specified by the indicated parameter, starting
+with 1.
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > I would split the "starting with 1" off into its own (full) sentence for clarity purposes. Also, please spell out one instead of 1.
> > 
> > You may also want to clarify how member functions do/do not impact this index.
> This does not appear to have been handled?
Ah, I missed that you wanted it in its own sentence, not just its own line.  I'll expand on this text in the next patch.


https://reviews.llvm.org/D29599





More information about the cfe-commits mailing list