[PATCH] D30760: Record command lines in objects built by clang, Clang part

[Eric Christopher via Phabricator via cfe-commits]

echristo added inline comments.


================
Comment at: test/Driver/debug-options.c:201-202
 //
+// GRECORD: "-dwarf-debug-flags"
+// GRECORD: -### -c -grecord-gcc-switches
+//
----------------
george.burgess.iv wrote:
> echristo wrote:
> > This seems a little light on the testing, would you mind adding some more interesting lines here? (Also, -grecord-gcc-switches seems like an option we might want to ignore for this?)
> re-pasting my comment, since it looks like it got dropped when we updated diffs:
> 
> nit: since `RenderAsInput` args (`-Xlinker`, `-o`, ...) have cases where they're printed without their arg, can we check that at least `-o -` is printed sanely, as well?
How about adding things like "-O3" or "-ffunction-sections" or something? Just useful options that we'd expect to see.


================
Comment at: test/Driver/debug-options.c:209
+// GNO_RECORD-NOT: "-dwarf-debug-flags"
+// GNO_RECORD-NOT: -### -c -greocrd-gcc-switches
+//
----------------
Typo.


https://reviews.llvm.org/D30760