[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld added a comment.

Having something with dashes behind other used prefixes (`CHK-PTXAS`, `CHK-PTXAS-C`, `CHK-PTXAS-C-RELO`) might not be optimal and break when other suffixes like `-NOT` or `-SAME` are added to lit. Please see inline about my suggestions but feel free to use others...



================
Comment at: test/Driver/openmp-offload.c:608
 
 // CHK-PTXAS: ptxas{{.*}}" "-c"
 // CHK-PTXAS-NEXT: /bin/cp
----------------
`CHK-PTXAS-DEFAULT` (to be changed in D29642)


================
Comment at: test/Driver/openmp-offload.c:617
+
+// CHK-PTXAS-C-NOT: ptxas{{.*}}" "-c"
+
----------------
`CHK-PTXAS-NORELO`


================
Comment at: test/Driver/openmp-offload.c:626
+
+// CHK-PTXAS-C-RELO: ptxas{{.*}}" "-c"
+
----------------
`CHK-PTXAS-RELO`


================
Comment at: test/Driver/openmp-offload.c:634
 
 // CHK-VERBOSE: ptxas{{.*}}" "-v"
 // CHK-VERBOSE-NEXT: /bin/cp
----------------
`CHK-PTXAS-VERBOSE` (to be changed in D29644)


Repository:
  rL LLVM

https://reviews.llvm.org/D29659