[PATCH] D31022: Implement P0298R3: `std::byte`

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added inline comments.


================
Comment at: test/std/language.support/support.types/byteops/xor.assign.pass.cpp:13
+
+// XFAIL: c++98, c++03, c++11, c++14
+
----------------
EricWF wrote:
> Nit. These should be `// UNSUPPORTED`. `XFAIL` is for bugs we need to fix.
I have mixed feeling about this, in some case I have a test that I want to make sure works in some conditions and does not in other. Using UNSUPPORTED will "hide" such cases if they're unexpectingly passing.

Having to duplicate the test identically in a ".failed.cpp" with a `REQUIRE:` identical to the `UNSUPPORTED` in the `.pass.cpp` is adding some unnecessary overhead and maintenance burden as well. 


https://reviews.llvm.org/D31022