[PATCH] D31363: [libc++] Remove cmake glob for source files

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 28 14:34:03 PDT 2017


smeenai planned changes to this revision.
smeenai added a comment.

I like the idea of verifying that all source files have been included. Will amend this accordingly. Thanks for the cmake pointer @beanz!



================
Comment at: lib/CMakeLists.txt:304
 if (LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY)
   file(GLOB LIBCXX_EXPERIMENTAL_SOURCES ../src/experimental/*.cpp)
   if (LIBCXX_ENABLE_FILESYSTEM)
----------------
EricWF wrote:
> These globs should be fixed as well.
Right, I missed this one.


https://reviews.llvm.org/D31363





More information about the cfe-commits mailing list