[PATCH] D27387: [libc++] Add a key function for bad_function_call

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 28 12:43:01 PDT 2017


smeenai added a comment.

In https://reviews.llvm.org/D27387#711866, @EricWF wrote:

> This LGTM, but I have a question: Should we add these dylib definitions right away so that it's easier to adopt the ABI change in future? This will allow legacy dylibs to support this ABI change in future. If you agree we can make that change as a follow up commit.


As in, leave the header as-is, but make the definitions in `functional.cpp` unconditional? I'm fine with that.


https://reviews.llvm.org/D27387





More information about the cfe-commits mailing list