[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

[Leslie Zhai via Phabricator via cfe-commits]

xiangzhai added a comment.

Hi Raphael,

Thanks for your reply!

> regarding performance: Last time I checked we spend most of the time on the verification of the hash values. We can do some tricks to make this faster (like delaying the verification to the end of the constraints where we have much less clones and therefore less overhead with this)
> 
> regarding false-positives: We will do some basic stuff to reduce them soon-ish (e.g. increasing the minimum clone size default value, filtering those generated files). Afterwards we probably need some fancier way of teaching the checker what is a valid clone and what not.
> 
> If you have some actual bugs that are found by the checker, please send them to me (teemperor [AT] gmail.com) that we can add them to the regression tests :)

I will test your updated patch tomorrow by testing with KDE/GNOME real projects.

Regards,
Leslie Zhai


https://reviews.llvm.org/D23418