[PATCH] D30268: Avoid copy of __atoms when char_type is char

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 27 19:51:43 PDT 2017


EricWF added a comment.

OK, so ABI wise this seems good. I'll need a fresh head to review the locale changes for correctness. I'll get around to that tomorrow.



================
Comment at: libcxx/include/locale:891
 
+#ifndef _LIBCPP_ABI_OPTIMIZED_LOCALE
 // signed
----------------
Would it be possible to reduce the amount of duplicate code between the two implementations? Currently it seems like there is a lot.


https://reviews.llvm.org/D30268





More information about the cfe-commits mailing list