[PATCH] D31363: [libc++] Remove cmake glob for source files
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 27 18:45:54 PDT 2017
EricWF added a comment.
Thanks for fixing this. Sucks that we have to manually enumerate source files but this is the correct solution according to CMake.
Would it be easy to still use `glob` to verify that none of the source files have accidentally been forgotten?
================
Comment at: lib/CMakeLists.txt:304
if (LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY)
file(GLOB LIBCXX_EXPERIMENTAL_SOURCES ../src/experimental/*.cpp)
if (LIBCXX_ENABLE_FILESYSTEM)
----------------
These globs should be fixed as well.
https://reviews.llvm.org/D31363
More information about the cfe-commits
mailing list