[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 27 15:08:40 PDT 2017


gtbercea added inline comments.


================
Comment at: lib/Driver/Tools.cpp:12136
   // Obtain architecture from the action.
-  CudaArch gpu_arch = StringToCudaArch(JA.getOffloadingArch());
   assert(gpu_arch != CudaArch::UNKNOWN &&
----------------
jlebar wrote:
> Why does JA.getOffloadingArch have the wrong value?  Isn't the purpose of JA.getOffloadingArch to have this particular value?  If it's broken, can we fix it instead of doing this hack?
I have to investigate this. Thanks for pointing this out.


Repository:
  rL LLVM

https://reviews.llvm.org/D29647





More information about the cfe-commits mailing list