[PATCH] D31399: [coroutines] Handle get_return_object_on_allocation_failure

[Eric Fiselier via Phabricator via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

This LGTM minus inline comments.



================
Comment at: lib/Sema/SemaCoroutine.cpp:793
+  LookupResult Found(S, DN, Loc, Sema::LookupMemberName);
+  // Suppress diagnostics when a private member is selected. The same warnings
+  // will be produced again when building the call.
----------------
Maybe add a test for this in `SemaCXX/coroutines.cpp`?


================
Comment at: test/CodeGenCoroutines/coro-alloc.cpp:131
+
+struct promise_on_alloc_failure_tag {};
+
----------------
FYI this test doesn't merge with trunk seemingly due to whitespace issues. 


https://reviews.llvm.org/D31399