[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 27 10:16:59 PDT 2017


ahatanak added inline comments.


================
Comment at: lib/Sema/SemaDecl.cpp:2157
   if (getDiagnostics().getSuppressSystemWarnings() &&
-      (Context.getSourceManager().isInSystemHeader(Old->getLocation()) ||
+      // Some standard types are defined implicitly in Clang (e.g. OpenCL).
+      (Old->isImplicit() || New->isImplicit() ||
----------------
Is it necessary to check whether New is implicit? I was just wondering when or how an implicit definition would redefine a typedef.


https://reviews.llvm.org/D31397





More information about the cfe-commits mailing list