[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

[András Leitereg via Phabricator via cfe-commits]

leanil updated this revision to Diff 93112.
leanil added a comment.
Herald added subscribers: ioeric, nemanjai.

Make the warning message more precise.
Add tests for implicitly declared constructors.


Repository:
  rL LLVM

https://reviews.llvm.org/D30547

Files:
  LICENSE.TXT
  change-namespace/ChangeNamespace.cpp
  change-namespace/ChangeNamespace.h
  change-namespace/tool/ClangChangeNamespace.cpp
  clang-move/ClangMove.cpp
  clang-tidy/CMakeLists.txt
  clang-tidy/ClangTidy.cpp
  clang-tidy/cppcoreguidelines/NoMallocCheck.cpp
  clang-tidy/cppcoreguidelines/NoMallocCheck.h
  clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
  clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
  clang-tidy/google/AvoidCStyleCastsCheck.cpp
  clang-tidy/google/ExplicitConstructorCheck.cpp
  clang-tidy/hicpp/CMakeLists.txt
  clang-tidy/hicpp/HICPPTidyModule.cpp
  clang-tidy/hicpp/LICENSE.TXT
  clang-tidy/hicpp/NoAssemblerCheck.cpp
  clang-tidy/hicpp/NoAssemblerCheck.h
  clang-tidy/misc/CMakeLists.txt
  clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp
  clang-tidy/misc/ForwardingReferenceOverloadCheck.h
  clang-tidy/misc/MiscTidyModule.cpp
  clang-tidy/misc/NoexceptMoveConstructorCheck.cpp
  clang-tidy/misc/UseAfterMoveCheck.cpp
  clang-tidy/modernize/UseAutoCheck.cpp
  clang-tidy/modernize/UseAutoCheck.h
  clang-tidy/modernize/UseNullptrCheck.cpp
  clang-tidy/modernize/UseOverrideCheck.cpp
  clang-tidy/readability/ContainerSizeEmptyCheck.cpp
  clang-tidy/readability/DeleteNullPointerCheck.cpp
  clang-tidy/readability/FunctionSizeCheck.cpp
  clang-tidy/readability/FunctionSizeCheck.h
  clang-tidy/readability/IdentifierNamingCheck.cpp
  clang-tidy/readability/IdentifierNamingCheck.h
  clang-tidy/readability/MisleadingIndentationCheck.cpp
  clang-tidy/readability/MisleadingIndentationCheck.h
  clang-tidy/readability/RedundantDeclarationCheck.cpp
  clang-tidy/safety/CMakeLists.txt
  clang-tidy/safety/NoAssemblerCheck.cpp
  clang-tidy/safety/NoAssemblerCheck.h
  clang-tidy/safety/SafetyTidyModule.cpp
  clang-tidy/tool/CMakeLists.txt
  clang-tidy/tool/ClangTidyMain.cpp
  clangd/ASTManager.cpp
  clangd/ASTManager.h
  clangd/CMakeLists.txt
  clangd/ClangDMain.cpp
  clangd/DocumentStore.h
  clangd/Protocol.cpp
  clangd/Protocol.h
  clangd/ProtocolHandlers.cpp
  clangd/ProtocolHandlers.h
  clangd/clients/clangd-vscode/.gitignore
  clangd/clients/clangd-vscode/.vscode/launch.json
  clangd/clients/clangd-vscode/.vscode/settings.json
  clangd/clients/clangd-vscode/.vscode/tasks.json
  clangd/clients/clangd-vscode/.vscodeignore
  clangd/clients/clangd-vscode/README.txt
  clangd/clients/clangd-vscode/package.json
  clangd/clients/clangd-vscode/src/extension.ts
  clangd/clients/clangd-vscode/test/extension.test.ts
  clangd/clients/clangd-vscode/test/index.ts
  clangd/clients/clangd-vscode/tsconfig.json
  clangd/clients/clangd-vscode/vsc-extension-quickstart.md
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/cppcoreguidelines-no-malloc.rst
  docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst
  docs/clang-tidy/checks/hicpp-no-assembler.rst
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/misc-argument-comment.rst
  docs/clang-tidy/checks/misc-forwarding-reference-overload.rst
  docs/clang-tidy/checks/modernize-use-emplace.rst
  docs/clang-tidy/checks/modernize-use-nullptr.rst
  docs/clang-tidy/checks/readability-function-size.rst
  docs/clang-tidy/checks/safety-no-assembler.rst
  docs/clang-tidy/index.rst
  include-fixer/CMakeLists.txt
  include-fixer/FuzzySymbolIndex.cpp
  include-fixer/FuzzySymbolIndex.h
  include-fixer/InMemorySymbolIndex.cpp
  include-fixer/InMemorySymbolIndex.h
  include-fixer/IncludeFixer.cpp
  include-fixer/SymbolIndex.h
  include-fixer/SymbolIndexManager.cpp
  include-fixer/YamlSymbolIndex.cpp
  include-fixer/YamlSymbolIndex.h
  include-fixer/find-all-symbols/FindAllMacros.cpp
  include-fixer/find-all-symbols/FindAllMacros.h
  include-fixer/find-all-symbols/FindAllSymbols.cpp
  include-fixer/find-all-symbols/FindAllSymbols.h
  include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
  include-fixer/find-all-symbols/SymbolInfo.cpp
  include-fixer/find-all-symbols/SymbolInfo.h
  include-fixer/find-all-symbols/SymbolReporter.h
  include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp
  include-fixer/tool/ClangIncludeFixer.cpp
  include-fixer/tool/clang-include-fixer-test.el
  include-fixer/tool/clang-include-fixer.el
  test/CMakeLists.txt
  test/change-namespace/Inputs/fake-std.h
  test/change-namespace/white-list.cpp
  test/clang-move/Inputs/var_test.cpp
  test/clang-move/Inputs/var_test.h
  test/clang-move/move-var.cpp
  test/clang-tidy/check_clang_tidy.py
  test/clang-tidy/clean-up-code.cpp
  test/clang-tidy/cppcoreguidelines-no-malloc-custom.cpp
  test/clang-tidy/cppcoreguidelines-no-malloc-no-functions.cpp
  test/clang-tidy/cppcoreguidelines-special-member-functions-cxx-03.cpp
  test/clang-tidy/cppcoreguidelines-special-member-functions-relaxed.cpp
  test/clang-tidy/cppcoreguidelines-special-member-functions.cpp
  test/clang-tidy/google-explicit-constructor.cpp
  test/clang-tidy/google-readability-casting.c
  test/clang-tidy/google-readability-casting.cpp
  test/clang-tidy/hicpp-no-assembler.cpp
  test/clang-tidy/misc-forwarding-reference-overload.cpp
  test/clang-tidy/misc-noexcept-move-constructor.cpp
  test/clang-tidy/misc-use-after-move.cpp
  test/clang-tidy/modernize-use-nullptr.cpp
  test/clang-tidy/modernize-use-override.cpp
  test/clang-tidy/readability-braces-around-statements-format.cpp
  test/clang-tidy/readability-container-size-empty.cpp
  test/clang-tidy/readability-function-size.cpp
  test/clang-tidy/readability-misleading-indentation.cpp
  test/clang-tidy/readability-redundant-declaration.cpp
  test/clang-tidy/safety-no-assembler.cpp
  test/clangd/fixits.test
  test/clangd/formatting.test
  test/include-fixer/Inputs/fake_yaml_db.yaml
  test/include-fixer/Inputs/merge/a.yaml
  test/include-fixer/Inputs/merge/b.yaml
  test/include-fixer/merge.test
  test/include-fixer/yaml_fuzzy.cpp
  unittests/CMakeLists.txt
  unittests/change-namespace/ChangeNamespaceTests.cpp
  unittests/clang-move/ClangMoveTests.cpp
  unittests/clang-rename/CMakeLists.txt
  unittests/clang-rename/ClangRenameTests.cpp
  unittests/include-fixer/CMakeLists.txt
  unittests/include-fixer/FuzzySymbolIndexTests.cpp
  unittests/include-fixer/IncludeFixerTest.cpp
  unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30547.93112.patch
Type: text/x-patch
Size: 303345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170327/d1f7dd06/attachment-0001.bin>