[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector
Vassil Vassilev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Mar 25 04:39:35 PDT 2017
v.g.vassilev added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:147
+ // different algorithm).
+ // TODO: In very big clones even multiple variables can be unintended,
+ // so replacing this number with a percentage could better handle such
----------------
Could you transform the TODO into a FIXME?
================
Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:172
// which may confuse the user.
// Think how to perform more accurate suggestions?
----------------
Could you add a FIXME here?
https://reviews.llvm.org/D23418
More information about the cfe-commits
mailing list