[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

Matthias Gehre via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 24 04:17:27 PDT 2017


mgehre added a comment.

Thanks for your feedback, Eugene!

I'm not sure if it would be helpful to have this check in both ways. I did a code search for "not_eq", "bitand" and "and_eq"
on github, and their usage seems to be a clear minority.

So I would propose to keep the features as-is for now,
change the name to readability-operators-representation, and then later (someone else?) might also add an option
for making this work the other way around. Would that be ok for you?

Were you refering to https://reviews.llvm.org/D25195 ("[lit] Fix FormatError on individual test timeout")?


Repository:
  rL LLVM

https://reviews.llvm.org/D31308





More information about the cfe-commits mailing list