[PATCH] D31166: Encapsulate FPOptions and use it consistently
Adam Nemet via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 23 22:30:10 PDT 2017
anemet marked 3 inline comments as done.
anemet added inline comments.
================
Comment at: lib/CodeGen/CGExprScalar.cpp:1712
BinOp.Opcode = IsInc ? BO_Add : BO_Sub;
- BinOp.FPContractable = false;
+ // FIXME: once UnaryOperator carries FPFeatures, copy it here.
BinOp.E = E;
----------------
aaron.ballman wrote:
> Why not make UnaryOperator carry this information now, since it's needed?
The trouble is that currently it's not needed. I'd rather wait for a fast-math flag that actually needs it so that we can write tests.
https://reviews.llvm.org/D31166
More information about the cfe-commits
mailing list