[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

[Brian T. Kelley via Phabricator via cfe-commits]

bkelley added inline comments.


================
Comment at: lib/AST/Type.cpp:3773
+/// lifetime semantics.
+bool Type::isNonTrivialObjCLifetimeType() const {
+  return CanonicalType.hasNonTrivialObjCLifetime();
----------------
rjmccall wrote:
> Is this method not identical in behavior to hasNonTrivialObjCLifetime()?
Yes, but I didn't see how to extract that information, which is on the internal QualType. But after examining the usage of this function in SemaInit.cpp:6681, I think we need something similar to the isObjCLifetimeType() implementation above.


https://reviews.llvm.org/D31007