[PATCH] D31210: [AMDGPU] Add new address space mapping

[Tom Stellard via Phabricator via cfe-commits]

tstellar added inline comments.


================
Comment at: lib/Basic/Targets.cpp:2029-2040
+      if (UseNew) {
+        Generic   = 0;
+        Global    = 1;
+        Local     = 3;
+        Constant  = 4;
+        Private   = 5;
+      } else {
----------------
What are these values used for?


================
Comment at: lib/Basic/Targets.cpp:2057
+          4,  // opencl_constant
+          0,  // opencl_generic
+          1,  // cuda_device
----------------
How will the backend deal with the fact that allocas return generic address space pointers?


https://reviews.llvm.org/D31210