[PATCH] D31183: [OpenCL] Added parsing for OpenCL vector types.

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

Although nothing wrong with the implementation apart from it complicates a bit the understanding of conventional C parse flow by adding extra corner case, I don't see anything in the spec that states explicitly how the vector components should be parsed. I guess with extra parenthesis the parsing problem can easily be avoided:

  ((int3)(32, 32, 32)).x 



================
Comment at: test/Parser/vector-cast-define.cl:11
+{
+    int index = dgSize.x * dgSize.y;
+}
----------------
I would prefer to simply the test and avoid using macros... it will be easier for us to maintain it in the future.


https://reviews.llvm.org/D31183