[PATCH] D30760: Record command lines in objects built by clang

Tue Mar 21 18:41:05 PDT 2017

aprantl added a comment.

In https://reviews.llvm.org/D30760#707178, @zhizhouy wrote:

> Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it seems that it really did the same work of recording command line options.
>
> And I noticed that it is set to false by default. Is it because of some concerns like the debug info size?

I think it is off by default because it doesn't really help the debugger and is more useful as a informational tool (e.g., when investigating compiler bugs). It also might leak unexpected information into the build (paths, macros, etc, ...) that a user might want to have control over.

> Is it proper to just set it to true when -grecord-gcc-switches exists on whatever platform?

I think so.

thanks,
adrian

https://reviews.llvm.org/D30760