[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

[Akira Hatanaka via Phabricator via cfe-commits]

ahatanak added a comment.

I think you can add a test case in this patch (after the llvm changes are checked in)?



================
Comment at: lib/CodeGen/CGExprScalar.cpp:262
+    ApplyFPFeatures(llvm::IRBuilderBase &Builder, Expr *E)
+        : CGBuilderTy::FastMathFlagGuard(Builder) {
+      if (const auto *BO = dyn_cast<BinaryOperator>(E)) {
----------------
Is it necessary to check CXXOperatorCallExpr too here? 

Since CXXOperatorCallExpr has an FPFeatures field too, I was wondering how CodeGen was going to use that information.


https://reviews.llvm.org/D31168