[PATCH] D31128: Rename the safety module to be hicpp

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 19 09:42:44 PDT 2017


aaron.ballman added inline comments.


================
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+  diag(ASMLocation, "do not use inline assembler in safety-critical code");
+}
----------------
jbcoe wrote:
> Should this message use text taken directly from the HICPP rules?
The wording from HICPP rule is too wishy-washy to be used as a diagnostic, IMO. It just says it "should be avoided". I think the current wording is reasonable.


https://reviews.llvm.org/D31128





More information about the cfe-commits mailing list