[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source code contains them.

[Hal Finkel via Phabricator via cfe-commits]

hfinkel added inline comments.


================
Comment at: include/clang/AST/ASTContext.h:1865
   /// arguments to the builtin that are required to be integer constant
   /// expressions.
   QualType GetBuiltinType(unsigned ID, GetBuiltinTypeError &Error,
----------------
Please add some description of the new parameters.


================
Comment at: include/clang/AST/ASTContext.h:1868
+                          bool *OverrideNonnullReturn = nullptr,
+                          unsigned *OverrideNonnullArgs = nullptr,
                           unsigned *IntegerConstantArgs = nullptr) const;
----------------
It seems like you had to touch more code than necessary because you decided to add these parameters before IntegerConstantArgs. Why don't you add them afterward instead?


https://reviews.llvm.org/D30806