[libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

[Eric Fiselier via cfe-commits]

Hi Bruno,

Thank you for the fix. I couldn't get to it today. I'll watch the sanitizer
bots more carefully in future.

On Mar 13, 2017 10:26 PM, "Bruno Cardoso Lopes" <bruno.cardoso at gmail.com>
wrote:

> Hi Eric,
>
> I fixed the build for darwin in r297703, let me know if you have any
> comments.
>
> Thanks,
>
> On Mon, Mar 13, 2017 at 3:04 PM, Bruno Cardoso Lopes
> <bruno.cardoso at gmail.com> wrote:
> > Hi Eric,
> >
> >>  if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR
> >> @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER)
> >>      message(WARNING "LLVM_USE_SANITIZER=${LLVM_USE_SANITIZER} is not
> supported on OS X")
> >>    endif()
> >>    if (LIBFILE)
> >> -    execute_process(COMMAND ${CMAKE_CXX_COMPILER} -print-file-name=lib
> OUTPUT_VARIABLE LIBDIR RESULT_VARIABLE Result)
> >> -    if (NOT ${Result} EQUAL "0")
> >> -      message(FATAL "Failed to find library resource directory")
> >> -    endif()
> >> -    string(STRIP "${LIBDIR}" LIBDIR)
> >> -    set(LIBDIR "${LIBDIR}/darwin/")
> >> +    find_compiler_rt_dir(LIBDIR)
> >
> > Seems like this broke ASAN+UBSAN bot in green-dragon:
> > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_build/3812
> >
> > Perhaps it's missing the "${LIBDIR}/darwin/" part from above?
> >
> > --
> > Bruno Cardoso Lopes
> > http://www.brunocardoso.cc
>
>
>
> --
> Bruno Cardoso Lopes
> http://www.brunocardoso.cc
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170314/e35d7bc2/attachment.html>