[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 13 15:37:41 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D30700#695358, @Hahnfeld wrote:

> No build system will ever set `-frtlib-add-rpath` to enable this "feature". I'm for keeping this opt-out until we have configuration files to set this by default. Making it opt-in would weaken its main reason of existence: Not to break simple binaries for the user, and we can just drop it.


I don't agree. If we want to be good citizens on Linux, what's supposed to happen is that we install our shared libraries into /usr/lib/${distro_target}, which is what GCC does with its shared compiler runtime libraries. GCC does not add system-specific absolute rpaths to the binaries it produces.


https://reviews.llvm.org/D30700





More information about the cfe-commits mailing list