[PATCH] D30881: Track skipped files in dependency scanning

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno added a comment.

Hi Pete,



================
Comment at: lib/Frontend/DependencyFile.cpp:191
+                   const Token &FilenameTok,
+                   SrcMgr::CharacteristicKind FileType) override;
+
----------------
Is there any `FileSkipped` callback invocation that might trigger an unwanted file to be added as a dependency or it will only trigger for the symlink case?


================
Comment at: test/Frontend/dependency-gen-symlink.c:11
+// RUN: echo "#endif" >> %t.dir/a/header.h
+// RUN: ln %t.dir/a/header.h %t.dir/b/header.h
+
----------------
It seems that it works for hard links as well right? Is this intended or do you miss a `-s`?


https://reviews.llvm.org/D30881