[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

[Egor Churaev via Phabricator via cfe-commits]

echuraev added inline comments.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+  "initialization of atomic variables is restricted to variables in global address space">;
 def err_atomic_init_constant : Error<
----------------
Anastasia wrote:
> Could we combine this error diag with the one below? I guess they are semantically very similar apart from one is about initialization and another is about assignment?
I'm not sure that it is a good idea to combine these errors. For example, if developer had declared a variable non-constant and not in global address space he would have got the same message for both errors. And it can be difficult to determine what the exact problem is. He can fix one of the problems but he will still get the same error.


https://reviews.llvm.org/D30643