[PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

[Juergen Ributzka via Phabricator via cfe-commits]

ributzka added inline comments.


================
Comment at: include/clang/Basic/VirtualFileSystem.h:164
     EC = Impl->increment();
-    if (EC || !Impl->CurrentEntry.isStatusKnown())
+    if (!Impl->CurrentEntry.isStatusKnown())
       Impl.reset(); // Normalize the end iterator to Impl == nullptr.
----------------
bruno wrote:
> I would rather we don't drop checks for `EC`s - it's commonly assumed that whenever they are passed in we wanna check them for errors, can't you just skip the specific case you want to avoid?
EC is an output parameter here. The client is supposed to check it.


https://reviews.llvm.org/D30768