[PATCH] D30792: Use callback for internalizing linked symbols.

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson added a comment.

Great, thanks. One question below and a format nit.



================
Comment at: lib/CodeGen/CodeGenAction.cpp:177
+        if (LM.Internalize) {
+	  Err = Linker::linkModules(
+	      *getModule(), std::move(LM.Module), LM.LinkFlags,
----------------
Needs clang-format (you can use git clang-format to change just the files in this patch if you use git).


================
Comment at: lib/CodeGen/CodeGenAction.cpp:186
+        } else {
+          Err = Linker::linkModules(*getModule(), std::move(LM.Module),
+                                    LM.LinkFlags);
----------------
Similar question (to what I added to the LLVM patch just now) as to why this is needed given the default for that parameter.


Repository:
  rL LLVM

https://reviews.llvm.org/D30792