[PATCH] D30693: [mips][msa] Remove range checks for non-immediate sld.[bhwd] instructions

Simon Dardis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 9 02:32:37 PST 2017


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM. Minor nit: there's some spurious whitespace that can be removed, see my inlined comment.



================
Comment at: test/CodeGen/builtins-mips-msa.c:701
   v2i64_r = __msa_sld_d(v2i64_r, v2i64_a, 1); // CHECK: call <2  x i64> @llvm.mips.sld.d(
+  
+  v16i8_r = __msa_sld_b(v16i8_r, v16i8_a, 16); // CHECK: call <16 x i8>  @llvm.mips.sld.b(
----------------
I'm seeing some whitespace here in the patch, remove it before committing please.


https://reviews.llvm.org/D30693





More information about the cfe-commits mailing list