[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 8 16:35:58 PST 2017


EricWF added inline comments.


================
Comment at: include/string:2559
 // replace
+// __sz += __n2 - __n1; in the two functions below can cause unsigned integer overflow,
+// but this is a safe operation, so we disable the check.
----------------
Please put this comment inside one of the function bodies, right above the offending line.

I think putting it here will result in it maybe becoming unmaintained. 


https://reviews.llvm.org/D30764





More information about the cfe-commits mailing list