[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 8 09:59:35 PST 2017
sammccall added a comment.
Thanks for the comments!
================
Comment at: include-fixer/SymbolIndexManager.cpp:106
// Match the identifier name without qualifier.
- if (Symbol.getName() == Names.back()) {
- bool IsMatched = true;
----------------
hokein wrote:
> Just want to verify: this judgement is not needed as it is guaranteed in Line 96 `DB.get()->search(Names.back())` right?
Yes. The existing non-fuzzy implementations all make this guarantee, and we decide that we'll accept results from fuzzy implementations now too.
https://reviews.llvm.org/D30720
More information about the cfe-commits
mailing list