[PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 6 19:50:36 PST 2017


mehdi_amini added inline comments.


================
Comment at: test/libcxx/test/config.py:66
         self.env = {}
         self.use_target = False
         self.use_system_cxx_lib = False
----------------
mehdi_amini wrote:
> EricWF wrote:
> > Was the omission of `self.use_deployment` here intentional? Python linters typically get upset by this.
> I can see how it would be useful not to add it here: we'd want an exception if it is used without being set since we don't expect it to happen.
> 
But if it is not considered "pythonic", I'm fine adding it as well :)


https://reviews.llvm.org/D17469





More information about the cfe-commits mailing list